Repository navigation
Wait node: palette chip, editor for the time, title shows it - #14
Merged
Merged
Conversation
A Wait node could only come from an imported file, its time could only be
changed in the file, and the node showed its display name or the bare
number. A value the engine cannot read ("20 s", "12,6") silently meant
"no wait".
- Palette: chip WAIT next to AND. Dropping it makes a Wait node with
1000 ms (ScenarioNodeViewModel.CreateStructural).
- Editor: double-click, right-click or Enter on a Wait node opens the
dialog "Wait" with the field "Wait time (ms)" (NodeMillisecondsViewModel,
NodeMillisecondsView, hosted in DialogWindow). It accepts a whole number
from 1 to 2147483647 in digits and writes it to TransactionName. Spaces
and characters nobody can see at the ends are ignored; inside the number
the message names them. Title, label and minimum are parameters, so
other node types with a time in ms can use it.
- Title: "Wait 1500 ms"; "Wait (invalid: 20 s)" or "Wait (no time set)"
for a value the engine does not wait for (WaitTime). A character nobody
can see in such a value shows as [U+00A0]. A display name no longer
replaces the time. A leading sign counts only if the culture of the
computer reads it too: the engine up to package 1.0.0-build-0027 reads
with that culture, a later one with the invariant culture.
- Wait nodes get their own colour on the canvas.
- README: how to make a Wait node. The sentence on node types no longer
says that Send & Wait waits for the reply or that Receive has a 30 s
timeout.
- specification/features.md and dialog_pattern.md.
New tests: WaitNodeTests and NodeMillisecondsViewModelTests (53 cases).
Internal board: secsgem/evencoolerfastsim issue 18.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Wait node could only come from an imported scenario file (internal board, issue 18). Its time could only be changed in the file, and on the canvas the node showed its display name or the bare number. A value the engine cannot read ("20 s", "12,6") silently meant "no wait".
The planned connection-drop scenario needs waits that can be set in the app. The editor is built so that the two coming node types with a time in ms (drop connection, wait for communication) can use it.
Changes
ScenarioNodeViewModel.CreateStructural).NodeMillisecondsViewModel,NodeMillisecondsView, hosted inDialogWindow).TransactionName.WaitTime.Title): "Wait 1500 ms". A value the engine does not wait for shows as "Wait (invalid: 20 s)" or "Wait (no time set)".[U+00A0].1.0.0-build-0027reads with that culture, the engine after SecsGemBase pull request 12 with the invariant culture. On Windows the two normally agree.specification/features.md(new section) andspecification/dialog_pattern.md(mapping rows).Known limits
1.0.0-build-0027skips the wait silently, and the title is then the only sign.ScenariosViewModel.OpenNodeEditor, the palette chip and the XAML have no unit test. The view model needs the whole DI graph and reads the user's profile in its constructor. They are covered by the run in the app below; the dialog mapping inWindowMapperhas a test.Verification
WaitNodeTestsandNodeMillisecondsViewModelTests.CanExecuteChangedfor the OK buttonwindows-latest.🤖 Generated with Claude Code